From af2d0c2e264cfe9d93c686d0c22cfa3408680d03 Mon Sep 17 00:00:00 2001 From: Christian Grothoff Date: Fri, 14 Oct 2011 08:55:32 +0000 Subject: [PATCH] comments --- src/ats/gnunet-service-ats_addresses.h | 6 ++++++ src/ats/gnunet-service-ats_performance.h | 2 ++ src/ats/gnunet-service-ats_scheduling.c | 18 +++++++++--------- src/ats/gnunet-service-ats_scheduling.h | 18 +++++++++--------- 4 files changed, 26 insertions(+), 18 deletions(-) diff --git a/src/ats/gnunet-service-ats_addresses.h b/src/ats/gnunet-service-ats_addresses.h index 4e27b96d2..f8fada2aa 100644 --- a/src/ats/gnunet-service-ats_addresses.h +++ b/src/ats/gnunet-service-ats_addresses.h @@ -60,8 +60,14 @@ GAS_address_destroyed (const struct GNUNET_PeerIdentity *peer, uint32_t session_id); +// FIXME: this function should likely end up in the LP-subsystem and +// not with 'addresses' in the future... +// Note: this call should trigger an address suggestion +// (GAS_scheduling_transmit_address_suggestion) void GAS_addresses_request_address (const struct GNUNET_PeerIdentity *peer); +/* FIXME: add performance request API */ + #endif diff --git a/src/ats/gnunet-service-ats_performance.h b/src/ats/gnunet-service-ats_performance.h index 24f65ed92..79ffeb5b3 100644 --- a/src/ats/gnunet-service-ats_performance.h +++ b/src/ats/gnunet-service-ats_performance.h @@ -91,5 +91,7 @@ void GAS_performance_done (void); +/* FIXME: add API to broadcast performance updates! */ + #endif /* end of gnunet-service-ats_performance.h */ diff --git a/src/ats/gnunet-service-ats_scheduling.c b/src/ats/gnunet-service-ats_scheduling.c index f97578384..76c192107 100644 --- a/src/ats/gnunet-service-ats_scheduling.c +++ b/src/ats/gnunet-service-ats_scheduling.c @@ -148,15 +148,15 @@ GAS_scheduling_remove_client (struct GNUNET_SERVER_Client *client) * @param bandwidth_in assigned inbound bandwidth */ void -GAS_scheduling_transmit_address_update (const struct GNUNET_PeerIdentity *peer, - const char *plugin_name, - const void *plugin_addr, size_t plugin_addr_len, - struct GNUNET_SERVER_Client *session_client, - uint32_t session_id, - const struct GNUNET_TRANSPORT_ATS_Information *atsi, - uint32_t atsi_count, - struct GNUNET_BANDWIDTH_Value32NBO bandwidth_out, - struct GNUNET_BANDWIDTH_Value32NBO bandwidth_in) +GAS_scheduling_transmit_address_suggestion (const struct GNUNET_PeerIdentity *peer, + const char *plugin_name, + const void *plugin_addr, size_t plugin_addr_len, + struct GNUNET_SERVER_Client *session_client, + uint32_t session_id, + const struct GNUNET_TRANSPORT_ATS_Information *atsi, + uint32_t atsi_count, + struct GNUNET_BANDWIDTH_Value32NBO bandwidth_out, + struct GNUNET_BANDWIDTH_Value32NBO bandwidth_in) { struct SchedulingClient *sc; struct AddressSuggestionMessage *msg; diff --git a/src/ats/gnunet-service-ats_scheduling.h b/src/ats/gnunet-service-ats_scheduling.h index d2506de6a..8d6fa977d 100644 --- a/src/ats/gnunet-service-ats_scheduling.h +++ b/src/ats/gnunet-service-ats_scheduling.h @@ -65,15 +65,15 @@ GAS_scheduling_remove_client (struct GNUNET_SERVER_Client *client); * @param bandwidth_in assigned inbound bandwidth */ void -GAS_scheduling_transmit_address_update (const struct GNUNET_PeerIdentity *peer, - const char *plugin_name, - const void *plugin_addr, size_t plugin_addr_len, - struct GNUNET_SERVER_Client *session_client, - uint32_t session_id, - const struct GNUNET_TRANSPORT_ATS_Information *atsi, - uint32_t atsi_count, - struct GNUNET_BANDWIDTH_Value32NBO bandwidth_out, - struct GNUNET_BANDWIDTH_Value32NBO bandwidth_in); +GAS_scheduling_transmit_address_suggestion (const struct GNUNET_PeerIdentity *peer, + const char *plugin_name, + const void *plugin_addr, size_t plugin_addr_len, + struct GNUNET_SERVER_Client *session_client, + uint32_t session_id, + const struct GNUNET_TRANSPORT_ATS_Information *atsi, + uint32_t atsi_count, + struct GNUNET_BANDWIDTH_Value32NBO bandwidth_out, + struct GNUNET_BANDWIDTH_Value32NBO bandwidth_in); /** -- 2.25.1