From aed4d5b7cb156a0fe66687f941a1aa79bf75efd1 Mon Sep 17 00:00:00 2001 From: Viktor Dukhovni Date: Mon, 16 May 2016 21:38:03 -0400 Subject: [PATCH] Clarify negative return from X509_verify_cert() Reviewed-by: Rich Salz --- doc/crypto/X509_verify_cert.pod | 13 +++++++------ 1 file changed, 7 insertions(+), 6 deletions(-) diff --git a/doc/crypto/X509_verify_cert.pod b/doc/crypto/X509_verify_cert.pod index a22e44118c..4689e3afea 100644 --- a/doc/crypto/X509_verify_cert.pod +++ b/doc/crypto/X509_verify_cert.pod @@ -31,12 +31,13 @@ Applications rarely call this function directly but it is used by OpenSSL internally for certificate validation, in both the S/MIME and SSL/TLS code. -The negative return value from X509_verify_cert() can only occur if no -certificate is set in B (due to a programming error); if X509_verify_cert() -twice without reinitialising B in between; or if a retry -operation is requested during internal lookups (which never happens with -standard lookup methods). It is however recommended that application check -for <= 0 return value on error. +A negative return value from X509_verify_cert() can occur if it is invoked +incorrectly, such as with no certificate set in B, or when it is called +twice in succession without reinitialising B for the second call. +A negative return value can also happen due to internal resource problems or if +a retry operation is requested during internal lookups (which never happens +with standard lookup methods). +Applications must check for <= 0 return value on error. =head1 BUGS -- 2.25.1