From ade4fccad6857f3d6d548e52bc94ab23751e4fef Mon Sep 17 00:00:00 2001 From: Guus Sliepen Date: Sat, 10 Nov 2012 23:13:05 +0100 Subject: [PATCH] Using alloca() for a constant sized buffer is very silly. Cppcheck said using alloca() in the 21st century is silly anyway. --- src/net_setup.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/net_setup.c b/src/net_setup.c index d53aad0..7485d21 100644 --- a/src/net_setup.c +++ b/src/net_setup.c @@ -393,7 +393,7 @@ char *get_name(void) { logger(DEBUG_ALWAYS, LOG_ERR, "Invalid Name: environment variable %s does not exist\n", name + 1); return false; } - envname = alloca(32); + char envname[32]; if(gethostname(envname, 32)) { logger(DEBUG_ALWAYS, LOG_ERR, "Could not get hostname: %s\n", strerror(errno)); return false; -- 2.25.1