From a9f7f1c58535af68efda0127322de30a33dd31b7 Mon Sep 17 00:00:00 2001 From: Peng Fan Date: Mon, 5 Nov 2018 09:53:28 +0000 Subject: [PATCH] tools: imx8image: fix coverity CID 184233 Fix: CID 184233: (NEGATIVE_RETURNS) Using variable "container" as an index to array "imx_header.fhdr". Reported-by: Coverity Signed-off-by: Peng Fan --- tools/imx8image.c | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/tools/imx8image.c b/tools/imx8image.c index 019b875773..ac89c821c9 100644 --- a/tools/imx8image.c +++ b/tools/imx8image.c @@ -812,6 +812,10 @@ static int build_container(soc_type_t soc, uint32_t sector_size, case SCFW: case DATA: case MSG_BLOCK: + if (container < 0) { + fprintf(stderr, "No container found\n"); + exit(EXIT_FAILURE); + } check_file(&sbuf, img_sp->filename); tmp_filename = img_sp->filename; set_image_array_entry(&imx_header.fhdr[container], @@ -825,6 +829,10 @@ static int build_container(soc_type_t soc, uint32_t sector_size, break; case SECO: + if (container < 0) { + fprintf(stderr, "No container found\n"); + exit(EXIT_FAILURE); + } check_file(&sbuf, img_sp->filename); tmp_filename = img_sp->filename; set_image_array_entry(&imx_header.fhdr[container], -- 2.25.1