From a905d13bbbd25c0976ba39a0f2e55033eeca26d7 Mon Sep 17 00:00:00 2001 From: David Benjamin Date: Wed, 10 Aug 2016 10:45:49 -0400 Subject: [PATCH] Don't test quite so many of them. Avoid making the CI blow up. Reviewed-by: Rich Salz Reviewed-by: Matt Caswell (cherry picked from commit 5cf6d7c51f16fd78de7921dc441e24897c8b3cc6) --- test/recipes/70-test_sslcbcpadding.t | 16 ++++++++++------ 1 file changed, 10 insertions(+), 6 deletions(-) diff --git a/test/recipes/70-test_sslcbcpadding.t b/test/recipes/70-test_sslcbcpadding.t index c6eca2f713..fddbeab015 100644 --- a/test/recipes/70-test_sslcbcpadding.t +++ b/test/recipes/70-test_sslcbcpadding.t @@ -34,18 +34,22 @@ my $proxy = TLSProxy::Proxy->new( (!$ENV{HARNESS_ACTIVE} || $ENV{HARNESS_VERBOSE}) ); -plan tests => 1 + 256; - my $bad_padding_offset = -1; -# Test 1: Maximally-padded records are accepted. +# TODO: We could test all 256 values, but then the log file gets too large for +# CI. See https://github.com/openssl/openssl/issues/1440. +my @test_offsets = (0, 128, 254, 255); + +plan tests => 1 + scalar(@test_offsets); + +# Test that maximally-padded records are accepted. $proxy->start() or plan skip_all => "Unable to start up Proxy for tests"; ok(TLSProxy::Message->success(), "Maximally-padded record test"); -# Tests 2 through 257: Invalid padding. -for ($bad_padding_offset = 0; $bad_padding_offset < 256; - $bad_padding_offset++) { +# Test that invalid padding is rejected. +foreach my $offset (@test_offsets) { $proxy->clear(); + $bad_padding_offset = $offset; $proxy->start() or plan skip_all => "Unable to start up Proxy for tests";; ok(TLSProxy::Message->fail(), "Invalid padding byte $bad_padding_offset"); } -- 2.25.1