From a5221b52064013137109e7aa659b661747f47e98 Mon Sep 17 00:00:00 2001 From: Bin Meng Date: Sat, 27 Feb 2016 22:57:58 -0800 Subject: [PATCH] x86: Change to use start/end address pair in write_tables() Add a new variable rom_table_start and pass it to ROM table write routines. This reads better than previous single rom_table_end. Signed-off-by: Bin Meng Reviewed-by: Simon Glass --- arch/x86/lib/tables.c | 18 ++++++++++++------ 1 file changed, 12 insertions(+), 6 deletions(-) diff --git a/arch/x86/lib/tables.c b/arch/x86/lib/tables.c index 14b15cf389..fc6c0d852a 100644 --- a/arch/x86/lib/tables.c +++ b/arch/x86/lib/tables.c @@ -39,26 +39,32 @@ void table_fill_string(char *dest, const char *src, size_t n, char pad) void write_tables(void) { - u32 __maybe_unused rom_table_end = ROM_TABLE_ADDR; + u32 __maybe_unused rom_table_start = ROM_TABLE_ADDR; + u32 __maybe_unused rom_table_end; #ifdef CONFIG_GENERATE_PIRQ_TABLE - rom_table_end = write_pirq_routing_table(rom_table_end); + rom_table_end = write_pirq_routing_table(rom_table_start); rom_table_end = ALIGN(rom_table_end, 1024); + rom_table_start = rom_table_end; #endif #ifdef CONFIG_GENERATE_SFI_TABLE - rom_table_end = write_sfi_table(rom_table_end); + rom_table_end = write_sfi_table(rom_table_start); rom_table_end = ALIGN(rom_table_end, 1024); + rom_table_start = rom_table_end; #endif #ifdef CONFIG_GENERATE_MP_TABLE - rom_table_end = write_mp_table(rom_table_end); + rom_table_end = write_mp_table(rom_table_start); rom_table_end = ALIGN(rom_table_end, 1024); + rom_table_start = rom_table_end; #endif #ifdef CONFIG_GENERATE_ACPI_TABLE - rom_table_end = write_acpi_tables(rom_table_end); + rom_table_end = write_acpi_tables(rom_table_start); rom_table_end = ALIGN(rom_table_end, 1024); + rom_table_start = rom_table_end; #endif #ifdef CONFIG_GENERATE_SMBIOS_TABLE - rom_table_end = write_smbios_table(rom_table_end); + rom_table_end = write_smbios_table(rom_table_start); rom_table_end = ALIGN(rom_table_end, 1024); + rom_table_start = rom_table_end; #endif } -- 2.25.1