From a50452e3e37bd3c79b4e69447420c8cd4cc2388b Mon Sep 17 00:00:00 2001 From: Jo-Philipp Wich Date: Sun, 8 Nov 2009 02:38:22 +0000 Subject: [PATCH] modules/admin-full: rewrite wifi join wizzard --- .../luasrc/controller/admin/network.lua | 76 +------ .../model/cbi/admin_network/iface_add.lua | 4 +- .../model/cbi/admin_network/wifi_add.lua | 211 ++++++++++++++++++ .../luasrc/view/admin_network/wifi_join.htm | 2 +- .../view/admin_network/wifi_join_settings.htm | 126 ----------- 5 files changed, 225 insertions(+), 194 deletions(-) create mode 100644 modules/admin-full/luasrc/model/cbi/admin_network/wifi_add.lua delete mode 100644 modules/admin-full/luasrc/view/admin_network/wifi_join_settings.htm diff --git a/modules/admin-full/luasrc/controller/admin/network.lua b/modules/admin-full/luasrc/controller/admin/network.lua index a5cc2c284..590b8f0ca 100644 --- a/modules/admin-full/luasrc/controller/admin/network.lua +++ b/modules/admin-full/luasrc/controller/admin/network.lua @@ -95,74 +95,20 @@ function wifi_join() local ssid = param("join") if dev and ssid then - local wep = (tonumber(param("wep")) == 1) - local wpa = tonumber(param("wpa_version")) or 0 - local channel = tonumber(param("channel")) - local mode = param("mode") - local bssid = param("bssid") + local cancel = (param("cancel") or param("cbi.cancel")) and true or false - local confirm = (param("confirm") == "1") - local cancel = param("cancel") and true or false - - if confirm and not cancel then - local fixed_bssid = (param("fixed_bssid") == "1") - local replace_net = (param("replace_net") == "1") - local autoconnect = (param("autoconnect") == "1") - local attach_intf = param("attach_intf") - - local uci = require "luci.model.uci".cursor() - - if replace_net then - uci:delete_all("wireless", "wifi-iface") - end - - local wificonf = { - device = dev, - mode = (mode == "Ad-Hoc" and "adhoc" or "sta"), - ssid = ssid - } - - if attach_intf and uci:get("network", attach_intf) == "interface" then - -- target network already has a interface, make it a bridge - uci:set("network", attach_intf, "type", "bridge") - uci:save("network") - uci:commit("network") - - wificonf.network = attach_intf - - if autoconnect then - require "luci.sys".call("/sbin/ifup " .. attach_intf) - end - end - - if fixed_bssid then - wificonf.bssid = bssid - end - - if wep then - wificonf.encryption = "wep" - wificonf.key = param("key") - elseif wpa > 0 then - wificonf.encryption = param("wpa_suite") - wificonf.key = param("key") - end - - local s = uci:section("wireless", "wifi-iface", nil, wificonf) - uci:delete("wireless", dev, "disabled") - uci:set("wireless", dev, "channel", channel) - - uci:save("wireless") - uci:commit("wireless") - - if autoconnect then - require "luci.sys".call("/sbin/wifi") - end - - luci.http.redirect(luci.dispatcher.build_url("admin/network/wireless")) - elseif cancel then + if cancel then luci.http.redirect(luci.dispatcher.build_url("admin/network/wireless_join?device=" .. dev)) else - luci.template.render("admin_network/wifi_join_settings") + local cbi = require "luci.cbi" + local tpl = require "luci.template" + local map = luci.cbi.load("admin_network/wifi_add")[1] + + if map:parse() ~= cbi.FORM_DONE then + tpl.render("header") + map:render() + tpl.render("footer") + end end else luci.template.render("admin_network/wifi_join") diff --git a/modules/admin-full/luasrc/model/cbi/admin_network/iface_add.lua b/modules/admin-full/luasrc/model/cbi/admin_network/iface_add.lua index 3dc0ac454..f623cac3f 100644 --- a/modules/admin-full/luasrc/model/cbi/admin_network/iface_add.lua +++ b/modules/admin-full/luasrc/model/cbi/admin_network/iface_add.lua @@ -35,7 +35,7 @@ newnet = m:field(Value, "_netname_new", translate("Name of the new network"), )) newnet:depends("_attach", "") -newnet.default = "net_" .. arg[1]:gsub("[^%w_]+", "_") +newnet.default = arg[1] and "net_" .. arg[1]:gsub("[^%w_]+", "_") addnet = m:field(Value, "_netname_attach", translate("Network to attach interface to")) @@ -52,7 +52,7 @@ fwzone = m:field(Value, "_fwzone", fwzone.template = "cbi/firewall_zonelist" addnet.widget = "radio" fwzone:depends("_attach", "") -fwzone.default = "zone_" .. arg[1]:gsub("[^%w_]+", "_") +fwzone.default = arg[1] and "zone_" .. arg[1]:gsub("[^%w_]+", "_") function attachnet.write(self, section, value) diff --git a/modules/admin-full/luasrc/model/cbi/admin_network/wifi_add.lua b/modules/admin-full/luasrc/model/cbi/admin_network/wifi_add.lua new file mode 100644 index 000000000..327f24e4f --- /dev/null +++ b/modules/admin-full/luasrc/model/cbi/admin_network/wifi_add.lua @@ -0,0 +1,211 @@ +--[[ +LuCI - Lua Configuration Interface + +Copyright 2009 Jo-Philipp Wich + +Licensed under the Apache License, Version 2.0 (the "License"); +you may not use this file except in compliance with the License. +You may obtain a copy of the License at + + http://www.apache.org/licenses/LICENSE-2.0 + +$Id$ +]]-- + +local nw = require "luci.model.network" +local fw = require "luci.model.firewall" +local wl = require "luci.model.wireless" +local uci = require "luci.model.uci".cursor() +local http = require "luci.http" + +local iw = luci.sys.wifi.getiwinfo(http.formvalue("device")) + +m = SimpleForm("network", translate("Join Network: Settings")) +m.cancel = translate("Back to scan results") +m.reset = false + +function m.on_cancel() + local dev = http.formvalue("device") + http.redirect(luci.dispatcher.build_url( + dev and "admin/network/wireless_join?device=" .. dev + or "admin/network/wireless" + )) +end + +nw.init(uci) +fw.init(uci) +wl.init(uci) + +m.hidden = { + device = http.formvalue("device"), + join = http.formvalue("join"), + channel = http.formvalue("channel"), + mode = http.formvalue("mode"), + bssid = http.formvalue("bssid"), + wep = http.formvalue("wep"), + wpa_suites = http.formvalue("wpa_suites"), + wpa_version = http.formvalue("wpa_version") +} + +if iw and iw.mbssid_support then + replace = m:field(Flag, "replace", translate("Replace wireless configuration"), + translate("An additional network will be created if you leave this unchecked.")) +else + replace = m:field(DummyValue, "replace", translate("Replace wireless configuration")) + replace.default = translate("The hardware is not multi-SSID capable and existing " .. + "configuration will be replaced if you proceed.") + + function replace.formvalue() return "1" end +end + +if http.formvalue("wep") == "1" then + key = m:field(Value, "key", translate("WEP passphrase"), + translate("Specify the secret encryption key here.")) + + key.password = true + +elseif (tonumber(m.hidden.wpa_version) or 0) > 0 and m.hidden.wpa_suites == "PSK" then + key = m:field(Value, "key", translate("WPA passphrase"), + translate("Specify the secret encryption key here.")) + + key.password = true + --m.hidden.wpa_suite = (tonumber(http.formvalue("wpa_version")) or 0) >= 2 and "psk2" or "psk" +end + +attachnet = m:field(Flag, "_attach", translate("Attach to existing network"), + translate("If the interface is attached to an existing network it will be bridged " .. + "to the existing interfaces and is covered by the firewall zone of the choosen network. " .. + "Uncheck this option to define a new standalone network." + )) + +attachnet.rmempty = false +attachnet.default = http.formvalue("cbi.submit") and nil or "1" + +function attachnet.formvalue(self, section) + if not http.formvalue("cbi.submit") then + return m.hidden.mode == "Ad-Hoc" and "0" or "1" + else + return Value.formvalue(self, section) and "1" or "0" + end +end + +attachnet.cfgvalue = attachnet.formvalue + +newnet = m:field(Value, "_netname_new", translate("Name of the new network"), + translate("The allowed characters are: A-Z, a-z, " .. + "0-9 and _" + )) + +newnet:depends("_attach", "") +newnet.default = m.hidden.mode == "Ad-Hoc" and "mesh" + +addnet = m:field(Value, "_netname_attach", + translate("Network to attach interface to")) + +addnet.template = "cbi/network_netlist" +addnet.widget = "radio" +addnet.default = "wan" +addnet.nocreate = true +addnet:depends("_attach", "1") + +fwzone = m:field(Value, "_fwzone", + translate("Create / Assign firewall-zone"), + translate("Choose the firewall zone you want to assign to this interface. Select unspecified to remove the interface from the associated zone or fill out the create field to define a new zone and attach the interface to it.")) + +fwzone.template = "cbi/firewall_zonelist" +fwzone:depends("_attach", "") +fwzone.default = m.hidden.mode == "Ad-Hoc" and "mesh" + +function attachnet.parse(self, section) + Flag.parse(self, section) + + if http.formvalue("cbi.submit") then + local net, zone + local value = self:formvalue(section) + + if value == "1" then + net = nw:get_network(addnet:formvalue(section)) + if net then + net:type("bridge") + end + else + local zval = fwzone:formvalue(section) + + net = nw:add_network(newnet:formvalue(section), { proto = "dhcp" }) + zone = fw:get_zone(zval) + + if not zone and zval == '-' then + zval = m:formvalue(fwzone:cbid(section) .. ".newzone") + if zval and #zval > 0 then + zone = fw:add_zone(zval) + end + end + end + + if not net then + self.error = { [section] = "missing" } + else + local wdev = wl:get_device(m.hidden.device) + wdev:disabled(false) + wdev:channel(m.hidden.channel) + + if replace:formvalue(section) then + local n + for _, n in ipairs(wdev:get_networks()) do + wl:del_network(n:name()) + end + end + + local wconf = { + device = m.hidden.device, + ssid = m.hidden.join, + mode = (m.hidden.mode == "Ad-Hoc" and "adhoc" or "sta"), + network = net:name() + } + + if m.hidden.wep == "1" then + wconf.encryption = "wep" + wconf.key = key and key:formvalue(section) or "" + elseif (tonumber(m.hidden.wpa_version) or 0) > 0 then + wconf.encryption = (tonumber(m.hidden.wpa_version) or 0) >= 2 and "psk2" or "psk" + wconf.key = key and key:formvalue(section) or "" + else + wconf.encryption = "none" + end + + if wconf.mode == "adhoc" then + wconf.bssid = m.hidden.bssid + end + + local wnet = wl:add_network(wconf) + + if wnet then + if zone then + fw:del_network(net:name()) + zone:add_network(net:name()) + end + + uci:save("wireless") + uci:save("network") + uci:save("firewall") + + uci:commit("wireless") + uci:commit("network") + uci:commit("firewall") + + luci.http.redirect(luci.dispatcher.build_url("admin/network/wireless", + wdev:name(), wnet:name())) + end + end + end +end + +attachnet.remove = attachnet.write + +function fwzone.cfgvalue(self, section) + self.iface = section + local z = fw:get_zone_by_network(section) + return z and z:name() +end + +return m diff --git a/modules/admin-full/luasrc/view/admin_network/wifi_join.htm b/modules/admin-full/luasrc/view/admin_network/wifi_join.htm index 43ba40bf1..6ed4627dc 100644 --- a/modules/admin-full/luasrc/view/admin_network/wifi_join.htm +++ b/modules/admin-full/luasrc/view/admin_network/wifi_join.htm @@ -71,7 +71,7 @@ $Id$ <%+header%> -

<%:Wireless Scan%>

+

<%:Join Network: Wireless Scan%>

diff --git a/modules/admin-full/luasrc/view/admin_network/wifi_join_settings.htm b/modules/admin-full/luasrc/view/admin_network/wifi_join_settings.htm deleted file mode 100644 index b29de61a0..000000000 --- a/modules/admin-full/luasrc/view/admin_network/wifi_join_settings.htm +++ /dev/null @@ -1,126 +0,0 @@ -<%# -LuCI - Lua Configuration Interface -Copyright 2009 Jo-Philipp Wich - -Licensed under the Apache License, Version 2.0 (the "License"); -you may not use this file except in compliance with the License. -You may obtain a copy of the License at - - http://www.apache.org/licenses/LICENSE-2.0 - -$Id$ - --%> - -<%- - - local sys = require "luci.sys" - local utl = require "luci.util" - local uci = require "luci.model.uci".cursor_state() - - local ifaces = { } - uci:foreach("network", "interface", function(i) - if i.ifname ~= "lo" then - ifaces[#ifaces+1] = { i['.name'], i.ifname, i.ipaddr } - end - end) - - local dev = luci.http.formvalue("device") - local iw = luci.sys.wifi.getiwinfo(dev) - - local requirement - - if iwinfo.type(dev) == "broadcom" and not nixio.fs.access("/usr/sbin/nas") then - requirement = luci.i18n.translatef("You need to install the Broadcom nas supplicant to use WPA!" - % luci.dispatcher.build_url("admin/system/packages?url=nas&submit=1")) - elseif not nixio.fs.access("/usr/sbin/wpa_supplicant") then - requirement = luci.i18n.translatef("You need to install wpa-supplicant to use WPA!" - % luci.dispatcher.build_url("admin/system/packages?url=wpa-supplicant&submit=1")) - end - --%> - -<%+header%> - -

<%:Join Network%>

- -
-
-
- <%=luci.i18n.translatef("You are about to join the wireless network %s. " .. - "In order to complete the process, you need to provide some additional details.", - utl.pcdata(luci.http.formvalue("join") or "(hidden)") - )%> -
- -
- - " /> - " /> - " /> - " /> - " /> - " /> - " /> - - <% if luci.http.formvalue("wep") == "1" then %> -
- -

- <% elseif tonumber(luci.http.formvalue("wpa_version") or 0) > 0 and luci.http.formvalue("wpa_suites") == "PSK" then %> -
- - - <% if tonumber(luci.http.formvalue("wpa_version") or 0) == 3 then %> - - <% else %> - " /> - <% end %> - - <% if requirement then %> -   <%=requirement%> - <% end %> - -

- <% end %> - -
- - -

-

- - <% if luci.http.formvalue("mode") == "Ad-Hoc" then %> - - -
- <% end %> - - <% if iw.mbssid_support then %> - - -
- <% else %> - - <% end %> - - - -
-
-
- - -
-
- -<%+footer%> -- 2.25.1