From 9fd8070c6395ee0ab6b5a7c0d98c370ce0847553 Mon Sep 17 00:00:00 2001 From: Tobias Schramm Date: Sun, 18 Feb 2018 13:46:04 +0100 Subject: [PATCH] uclient-fetch: Check for nullpointer returned by uclient_get_url_filename uclient_get_url_filename may return a null ptr resulting in a null ptr dereference by fprintf and open Signed-off-by: Tobias Schramm --- uclient-fetch.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/uclient-fetch.c b/uclient-fetch.c index 6961d94..38c9c53 100644 --- a/uclient-fetch.c +++ b/uclient-fetch.c @@ -122,6 +122,11 @@ static int open_output_file(const char *path, uint64_t resume_offset) } } else { filename = uclient_get_url_filename(path, "index.html"); + if (!filename) { + ret = -ENOMEM; + goto out; + } + output_file = filename; } @@ -151,6 +156,7 @@ done: free: free(filename); +out: return ret; } -- 2.25.1