From 9e663b13714f36a2069cfddf493a5d27985e26a0 Mon Sep 17 00:00:00 2001 From: Matt Caswell Date: Fri, 14 Oct 2016 15:55:49 +0100 Subject: [PATCH] Add a comment to 90-test_external.t to explain why we need filter_run Also rename executable to cmd...otherwise it breaks! Reviewed-by: Richard Levitte --- test/recipes/90-test_external.t | 15 +++++++++------ 1 file changed, 9 insertions(+), 6 deletions(-) diff --git a/test/recipes/90-test_external.t b/test/recipes/90-test_external.t index d08d66faad..49e2bd2005 100644 --- a/test/recipes/90-test_external.t +++ b/test/recipes/90-test_external.t @@ -20,14 +20,17 @@ if (!$ENV{BORING_RUNNER_DIR}) { plan tests => 1; indir $ENV{BORING_RUNNER_DIR} => sub { - ok(filter_run(executable(["go", "test", "-shim-path", - srctop_file("test", "ossl_shim", "ossl_shim"), - "-shim-config", - srctop_file("test", "ossl_shim", - "ossl_config.json"), - "-pipe"])), + ok(filter_run(cmd(["go", "test", "-shim-path", + srctop_file("test", "ossl_shim", "ossl_shim"), + "-shim-config", + srctop_file("test", "ossl_shim", "ossl_config.json"), + "-pipe"])), + "running external tests"); }, create => 0, cleanup => 0; +# Filter the output so that the "ok" printed by go test doesn't confuse +# Test::More. Without that it thinks there has been one more test run than was +# planned sub filter_run { my $cmd = cmdstr(shift); open(PIPE, "-|", $cmd); -- 2.25.1