From 9e64457d1ed6200228a930ab14c5c5e68a666d1e Mon Sep 17 00:00:00 2001 From: Richard Levitte Date: Tue, 19 Jul 2016 08:57:01 +0200 Subject: [PATCH] Have 'openssl engine' exit with non-zero when some engine fails to load Reviewed-by: Rich Salz --- apps/engine.c | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/apps/engine.c b/apps/engine.c index c98839a9fc..ffd3137426 100644 --- a/apps/engine.c +++ b/apps/engine.c @@ -342,6 +342,7 @@ int engine_main(int argc, char **argv) } } + ret = 0; for (i = 0; i < sk_OPENSSL_CSTRING_num(engines); i++) { const char *id = sk_OPENSSL_CSTRING_value(engines, i); if ((e = ENGINE_by_id(id)) != NULL) { @@ -424,11 +425,14 @@ int engine_main(int argc, char **argv) if ((verbose > 0) && !util_verbose(e, verbose, out, indent)) goto end; ENGINE_free(e); - } else + } else { ERR_print_errors(bio_err); + /* because exit codes above 127 have special meaning on Unix */ + if (++ret > 127) + ret = 127; + } } - ret = 0; end: ERR_print_errors(bio_err); -- 2.25.1