From 9ce798abd4da80a5769f493a3aea729781cfae97 Mon Sep 17 00:00:00 2001 From: Jo-Philipp Wich Date: Wed, 10 Feb 2016 19:29:29 +0100 Subject: [PATCH] luci-base: cbi: properly handle dependant elements without parent Signed-off-by: Jo-Philipp Wich --- modules/luci-base/htdocs/luci-static/resources/cbi.js | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/modules/luci-base/htdocs/luci-static/resources/cbi.js b/modules/luci-base/htdocs/luci-static/resources/cbi.js index a1491cc66..f58306954 100644 --- a/modules/luci-base/htdocs/luci-static/resources/cbi.js +++ b/modules/luci-base/htdocs/luci-static/resources/cbi.js @@ -454,7 +454,7 @@ function cbi_d_update() { if (node && node.parentNode && !cbi_d_check(entry.deps)) { node.parentNode.removeChild(node); state = true; - } else if ((!node || !node.parentNode) && cbi_d_check(entry.deps)) { + } else if (parent && (!node || !node.parentNode) && cbi_d_check(entry.deps)) { var next = undefined; for (next = parent.firstChild; next; next = next.nextSibling) { @@ -473,7 +473,7 @@ function cbi_d_update() { } // hide optionals widget if no choices remaining - if (parent.parentNode && parent.getAttribute('data-optionals')) + if (parent && parent.parentNode && parent.getAttribute('data-optionals')) parent.parentNode.style.display = (parent.options.length <= 1) ? 'none' : ''; } -- 2.25.1