From 9ca48ecc93d70c43956ef985bb8384105d1eec46 Mon Sep 17 00:00:00 2001 From: Jo-Philipp Wich Date: Wed, 4 Dec 2019 18:04:20 +0100 Subject: [PATCH] luci-base: ui.js: ensure that select choice labels are properly escaped Signed-off-by: Jo-Philipp Wich (cherry picked from commit 71d370a964f3ec4970bcded9198ff559316902ff) --- modules/luci-base/htdocs/luci-static/resources/ui.js | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/modules/luci-base/htdocs/luci-static/resources/ui.js b/modules/luci-base/htdocs/luci-static/resources/ui.js index f90de9e73..7f13e249a 100644 --- a/modules/luci-base/htdocs/luci-static/resources/ui.js +++ b/modules/luci-base/htdocs/luci-static/resources/ui.js @@ -312,7 +312,7 @@ var UISelect = UIElement.extend({ frameEl.lastChild.appendChild(E('option', { 'value': '', 'selected': (this.values.length == 0 || this.values[0] == '') ? '' : null - }, this.choices[''] || this.options.placeholder || _('-- Please choose --'))); + }, [ this.choices[''] || this.options.placeholder || _('-- Please choose --') ])); for (var i = 0; i < keys.length; i++) { if (keys[i] == null || keys[i] == '') @@ -321,7 +321,7 @@ var UISelect = UIElement.extend({ frameEl.lastChild.appendChild(E('option', { 'value': keys[i], 'selected': (this.values.indexOf(keys[i]) > -1) ? '' : null - }, this.choices[keys[i]] || keys[i])); + }, [ this.choices[keys[i]] || keys[i] ])); } } else { -- 2.25.1