From 9b83182069cc3b213277104a992e195982060146 Mon Sep 17 00:00:00 2001 From: Rich Felker Date: Sat, 6 Jul 2019 17:47:43 -0400 Subject: [PATCH] fix inadvertent use of uninitialized variable in dladdr commit c8b49b2fbc7faa8bf065220f11963d76c8a2eb93 introduced code that checked bestsym to determine whether a matching symbol was found, but bestsym is uninitialized if not. instead use best, consistent with use in the rest of the function. simplified from bug report and patch by Cheng Liu. --- ldso/dynlink.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ldso/dynlink.c b/ldso/dynlink.c index db543c19..d1edb131 100644 --- a/ldso/dynlink.c +++ b/ldso/dynlink.c @@ -2217,7 +2217,7 @@ int dladdr(const void *addr_arg, Dl_info *info) } } - if (bestsym && besterr > bestsym->st_size-1) { + if (best && besterr > bestsym->st_size-1) { best = 0; bestsym = 0; } -- 2.25.1