From 97ba39547d4c79b60131475a1512cc7d7e8952b2 Mon Sep 17 00:00:00 2001 From: Richard Levitte Date: Tue, 10 Dec 2019 20:38:09 +0100 Subject: [PATCH] test/namemap_internal_test.c: use "cookie" instead of "foo"... ... in test_namemap() Because tests may sometimes run in random order (subject of the environment variable OPENSSL_TEST_RAND_ORDER being defined), and we're dealing with the global namemap, each test must use names that are globally unique for that test. Unfortunately, we used "foo" in two of them, which might lead to surprising results. Fixes #10401 Reviewed-by: Tomas Mraz (Merged from https://github.com/openssl/openssl/pull/10601) --- test/namemap_internal_test.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/test/namemap_internal_test.c b/test/namemap_internal_test.c index 0b67cb1d3f..263364adbd 100644 --- a/test/namemap_internal_test.c +++ b/test/namemap_internal_test.c @@ -26,7 +26,7 @@ static int test_namemap(OSSL_NAMEMAP *nm) int check2 = ossl_namemap_name2num(nm, NAME2); int check3 = ossl_namemap_name2num(nm, ALIAS1); int check4 = ossl_namemap_name2num(nm, ALIAS1_UC); - int false1 = ossl_namemap_name2num(nm, "foo"); + int false1 = ossl_namemap_name2num(nm, "cookie"); return TEST_int_ne(num1, 0) && TEST_int_ne(num2, 0) -- 2.25.1