From 9705b53322cbc1a151a0888032c34fcad40a6144 Mon Sep 17 00:00:00 2001 From: Kevin Darbyshire-Bryant Date: Thu, 14 Nov 2019 10:53:56 +0000 Subject: [PATCH] luci-base: Improve change application message As a native English speaker the luci message displayed when clicking 'Save & Apply' has a somewhat uncomfortable English phrasing of "Waiting for configuration to get applied". It could be improved by replacing 'get' with 'be' but once you've got that far you might as well replace this with the shorter & simpler "Applying configuration changes". This is also technically more correct since luci/openwrt should only be updating/restarting processes that are related to the changed areas, not changing the entire configuration. As a result of that, change both the 'success' and 'rolled back' messages to "Configuration changes have been applied" & "Configuration changes have been rolled back" Signed-off-by: Kevin Darbyshire-Bryant (cherry picked from commit 9b266d11c6b5082c733f101326160cef797f6edf) --- modules/luci-base/htdocs/luci-static/resources/ui.js | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/modules/luci-base/htdocs/luci-static/resources/ui.js b/modules/luci-base/htdocs/luci-static/resources/ui.js index 2e295077f..52c1025bf 100644 --- a/modules/luci-base/htdocs/luci-static/resources/ui.js +++ b/modules/luci-base/htdocs/luci-static/resources/ui.js @@ -3839,7 +3839,7 @@ return L.Class.extend(/** @lends LuCI.ui.prototype */ { var call = function(r, data, duration) { if (r.status === 204) { L.ui.changes.displayStatus('warning', [ - E('h4', _('Configuration has been rolled back!')), + E('h4', _('Configuration changes have been rolled back!')), E('p', _('The device could not be reached within %d seconds after applying the pending changes, which caused the configuration to be rolled back for safety reasons. If you believe that the configuration changes are correct nonetheless, perform an unchecked configuration apply. Alternatively, you can dismiss this warning and edit changes before attempting to apply again, or revert all pending changes to keep the currently working configuration state.').format(L.env.apply_rollback)), E('div', { 'class': 'right' }, [ E('button', { @@ -3901,7 +3901,7 @@ return L.Class.extend(/** @lends LuCI.ui.prototype */ { L.ui.changes.setIndicator(0); L.ui.changes.displayStatus('notice', - E('p', _('Configuration has been applied.'))); + E('p', _('Configuration changes applied.'))); window.clearTimeout(tt); window.setTimeout(function() { @@ -3926,7 +3926,7 @@ return L.Class.extend(/** @lends LuCI.ui.prototype */ { var now = Date.now(); L.ui.changes.displayStatus('notice spinning', - E('p', _('Waiting for configuration to get applied… %ds') + E('p', _('Applying configuration changes… %ds') .format(Math.max(Math.floor((deadline - Date.now()) / 1000), 0)))); if (now >= deadline) -- 2.25.1