From 956de7b2873e0dde61b287049cd0eb35756b6207 Mon Sep 17 00:00:00 2001 From: Matt Caswell Date: Mon, 26 Oct 2015 14:05:43 +0000 Subject: [PATCH] Remove superfluous check |tls_process_finished| was checking that |peer_finish_md_len| was non-negative. However neither |tls1_final_finish_mac| or |ssl3_final_finish_mac| can ever return a negative value, so the check is superfluous. Reviewed-by: Tim Hudson Reviewed-by: Richard Levitte --- ssl/statem/statem_lib.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ssl/statem/statem_lib.c b/ssl/statem/statem_lib.c index f2a2925deb..2c100dc817 100644 --- a/ssl/statem/statem_lib.c +++ b/ssl/statem/statem_lib.c @@ -306,7 +306,7 @@ MSG_PROCESS_RETURN tls_process_finished(SSL *s, PACKET *pkt) i = s->s3->tmp.peer_finish_md_len; - if (i < 0 || (unsigned long)i != PACKET_remaining(pkt)) { + if ((unsigned long)i != PACKET_remaining(pkt)) { al = SSL_AD_DECODE_ERROR; SSLerr(SSL_F_TLS_PROCESS_FINISHED, SSL_R_BAD_DIGEST_LENGTH); goto f_err; -- 2.25.1