From 950d49d43900e67a1f9d02bc1a053a9fdc5c4257 Mon Sep 17 00:00:00 2001 From: Pavel Kopyl Date: Fri, 27 Oct 2017 16:13:11 +0300 Subject: [PATCH] Add error handling in dsa_main and ASN1_i2d_bio. CLA: trivial Reviewed-by: Kurt Roeckx Reviewed-by: Bernd Edlinger (Merged from https://github.com/openssl/openssl/pull/4600) (cherry picked from commit a6f622bc99ffdc7b34199babb9d200b24a7a6431) --- apps/dsa.c | 3 +++ crypto/asn1/a_i2d_fp.c | 3 +++ 2 files changed, 6 insertions(+) diff --git a/apps/dsa.c b/apps/dsa.c index 4ed21d891e..82a870eb29 100644 --- a/apps/dsa.c +++ b/apps/dsa.c @@ -327,6 +327,9 @@ int MAIN(int argc, char **argv) } else if (outformat == FORMAT_MSBLOB || outformat == FORMAT_PVK) { EVP_PKEY *pk; pk = EVP_PKEY_new(); + if (pk == NULL) + goto end; + EVP_PKEY_set1_DSA(pk, dsa); if (outformat == FORMAT_PVK) i = i2b_PVK_bio(out, pk, pvk_encr, 0, passout); diff --git a/crypto/asn1/a_i2d_fp.c b/crypto/asn1/a_i2d_fp.c index 0f56cd4e07..2e85e041e4 100644 --- a/crypto/asn1/a_i2d_fp.c +++ b/crypto/asn1/a_i2d_fp.c @@ -87,6 +87,9 @@ int ASN1_i2d_bio(i2d_of_void *i2d, BIO *out, unsigned char *x) int i, j = 0, n, ret = 1; n = i2d(x, NULL); + if (n <= 0) + return 0; + b = (char *)OPENSSL_malloc(n); if (b == NULL) { ASN1err(ASN1_F_ASN1_I2D_BIO, ERR_R_MALLOC_FAILURE); -- 2.25.1