From 92aa50bc0367d43b74b70f70da1500430daee1fd Mon Sep 17 00:00:00 2001 From: "Dr. Stephen Henson" Date: Tue, 28 Feb 2012 14:47:25 +0000 Subject: [PATCH] Fix memory leak cause by race condition when creating public keys. Thanks to Ivan Nestlerode for reporting this bug. --- crypto/asn1/x_pubkey.c | 11 ++++++++++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/crypto/asn1/x_pubkey.c b/crypto/asn1/x_pubkey.c index d42b6a2c54..627ec87f9f 100644 --- a/crypto/asn1/x_pubkey.c +++ b/crypto/asn1/x_pubkey.c @@ -171,7 +171,16 @@ EVP_PKEY *X509_PUBKEY_get(X509_PUBKEY *key) goto error; } - key->pkey = ret; + /* Check to see if another thread set key->pkey first */ + CRYPTO_w_lock(CRYPTO_LOCK_EVP_PKEY); + if (key->pkey) + { + EVP_PKEY_free(ret); + ret = key->pkey; + } + else + key->pkey = ret; + CRYPTO_w_unlock(CRYPTO_LOCK_EVP_PKEY); CRYPTO_add(&ret->references, 1, CRYPTO_LOCK_EVP_PKEY); return ret; -- 2.25.1