From 91c4f7f0ea0b653d15bfabc05f5474f8fa1a8806 Mon Sep 17 00:00:00 2001 From: =?utf8?q?Lo=C3=AFc=20Blot?= Date: Mon, 27 Apr 2020 11:27:27 +0200 Subject: [PATCH] Forbid object:attach(obj, ...) (#9762) Fixes #9761 --- src/script/lua_api/l_object.cpp | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/src/script/lua_api/l_object.cpp b/src/script/lua_api/l_object.cpp index d7afb84da..77e1e7dc2 100644 --- a/src/script/lua_api/l_object.cpp +++ b/src/script/lua_api/l_object.cpp @@ -674,8 +674,13 @@ int ObjectRef::l_set_attach(lua_State *L) ServerActiveObject *parent = getobject(parent_ref); if (co == NULL) return 0; + if (parent == NULL) return 0; + + if (co == parent) + throw LuaError("ObjectRef::set_attach: attaching object to itself is not allowed."); + // Do it int parent_id = 0; std::string bone; -- 2.25.1