From 91b5b2e20d531584918c62a6c6cd046f0580f50a Mon Sep 17 00:00:00 2001 From: Ivan Shapovalov Date: Mon, 14 May 2018 00:05:43 +0300 Subject: [PATCH] netifd: drop conflicting 'device' interface property Do not set device runtime property on interfaces in the hotplug handler and in fixup_interfaces(). This property conflicts with device option in several proto handlers (mainly QMI and other WWAN/3G protos) and does not seem to be used anywhere. Signed-off-by: Ivan Shapovalov Signed-off-by: Hans Dedecker [PKG_RELEASE increase] --- package/network/config/netifd/Makefile | 2 +- .../config/netifd/files/etc/hotplug.d/iface/00-netstate | 1 - package/network/config/netifd/files/lib/network/config.sh | 3 --- 3 files changed, 1 insertion(+), 5 deletions(-) diff --git a/package/network/config/netifd/Makefile b/package/network/config/netifd/Makefile index 874183507f..7e739ab6bc 100644 --- a/package/network/config/netifd/Makefile +++ b/package/network/config/netifd/Makefile @@ -1,7 +1,7 @@ include $(TOPDIR)/rules.mk PKG_NAME:=netifd -PKG_RELEASE:=1 +PKG_RELEASE:=2 PKG_SOURCE_PROTO:=git PKG_SOURCE_URL=$(PROJECT_GIT)/project/netifd.git diff --git a/package/network/config/netifd/files/etc/hotplug.d/iface/00-netstate b/package/network/config/netifd/files/etc/hotplug.d/iface/00-netstate index 023025cd1a..71ccb01915 100644 --- a/package/network/config/netifd/files/etc/hotplug.d/iface/00-netstate +++ b/package/network/config/netifd/files/etc/hotplug.d/iface/00-netstate @@ -1,7 +1,6 @@ [ ifup = "$ACTION" ] && { uci_toggle_state network "$INTERFACE" up 1 [ -n "$DEVICE" ] && { - uci_toggle_state network "$INTERFACE" device "$(uci -q get network.$INTERFACE.ifname)" uci_toggle_state network "$INTERFACE" ifname "$DEVICE" } } diff --git a/package/network/config/netifd/files/lib/network/config.sh b/package/network/config/netifd/files/lib/network/config.sh index 9128971dab..0ded45edc4 100755 --- a/package/network/config/netifd/files/lib/network/config.sh +++ b/package/network/config/netifd/files/lib/network/config.sh @@ -41,15 +41,12 @@ fixup_interface() { config_get type "$config" type config_get ifname "$config" ifname - config_get device "$config" device "$ifname" [ "bridge" = "$type" ] && ifname="br-$config" - config_set "$config" device "$ifname" ubus_call "network.interface.$config" status || return 0 json_get_var l3dev l3_device [ -n "$l3dev" ] && ifname="$l3dev" json_init config_set "$config" ifname "$ifname" - config_set "$config" device "$device" } scan_interfaces() { -- 2.25.1