From 906cc858fe8d5e23b10939d515cb7a58cfe042de Mon Sep 17 00:00:00 2001 From: Christian Grothoff Date: Wed, 20 Oct 2010 08:01:20 +0000 Subject: [PATCH] fixing off-by-one --- src/util/network.c | 12 ++++++++---- 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/src/util/network.c b/src/util/network.c index cf74d43ad..a1142d433 100644 --- a/src/util/network.c +++ b/src/util/network.c @@ -900,12 +900,16 @@ GNUNET_NETWORK_fdset_overlap (const struct GNUNET_NETWORK_FDSet *fds1, const struct GNUNET_NETWORK_FDSet *fds2) { int nfds; + nfds = fds1->nsds; - if (nfds < fds2->nsds) + if (nfds > fds2->nsds) nfds = fds2->nsds; - for (; nfds >= 0; nfds--) - if (FD_ISSET (nfds, &fds1->sds) && FD_ISSET (nfds, &fds2->sds)) - return GNUNET_YES; + while (nfds > 0) + { + nfds--; + if (FD_ISSET (nfds, &fds1->sds) && FD_ISSET (nfds, &fds2->sds)) + return GNUNET_YES; + } #ifdef MINGW { struct GNUNET_CONTAINER_SList_Iterator *it; -- 2.25.1