From 8e3854ac88836df0ba862b1aba851dcd963c4ad2 Mon Sep 17 00:00:00 2001 From: Matt Caswell Date: Thu, 21 Jul 2016 10:28:24 +0100 Subject: [PATCH] Don't double free the write bio When setting the read bio we free up any old existing one. However this can lead to a double free if the existing one is the same as the write bio. Reviewed-by: Rich Salz --- ssl/ssl_lib.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ssl/ssl_lib.c b/ssl/ssl_lib.c index 4288c6fbbc..c49fc5c704 100644 --- a/ssl/ssl_lib.c +++ b/ssl/ssl_lib.c @@ -1045,7 +1045,7 @@ void SSL_free(SSL *s) void SSL_set_rbio(SSL *s, BIO *rbio) { - if (s->rbio != rbio) + if (s->rbio != rbio && s->rbio != s->wbio) BIO_free_all(s->rbio); s->rbio = rbio; } -- 2.25.1