From 871ba2df73dd42ee9fa80533dd924f192f0b3b25 Mon Sep 17 00:00:00 2001 From: Jo-Philipp Wich Date: Tue, 30 Sep 2008 20:53:46 +0000 Subject: [PATCH] * luci/app/firewall: - remove empty value from src zone, param is mandatory - add empty value to outgoing zone to allow removal of this param - change default action to "accept" to prevent unwanted lockouts --- applications/luci-fw/luasrc/model/cbi/luci_fw/firewall.lua | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/applications/luci-fw/luasrc/model/cbi/luci_fw/firewall.lua b/applications/luci-fw/luasrc/model/cbi/luci_fw/firewall.lua index 8ff03b02d..0d9af93fc 100644 --- a/applications/luci-fw/luasrc/model/cbi/luci_fw/firewall.lua +++ b/applications/luci-fw/luasrc/model/cbi/luci_fw/firewall.lua @@ -18,10 +18,10 @@ s.addremove = true s.anonymous = true iface = s:option(ListValue, "src") -iface:value("") iface.rmempty = true oface = s:option(ListValue, "dest") +oface:value("") oface.optional = true luci.model.uci.cursor():foreach("firewall", "zone", @@ -56,6 +56,7 @@ dport:depends("proto", "tcpudp") jump = s:option(ListValue, "target") jump.rmempty = true +jump.default = "ACCEPT" jump:value("DROP", translate("fw_drop")) jump:value("ACCEPT", translate("fw_accept")) jump:value("REJECT", translate("fw_reject")) -- 2.25.1