From 863073da0858b07149d4c15d13d1ac0b1a769eb0 Mon Sep 17 00:00:00 2001 From: Bernhard Reutner-Fischer Date: Sun, 4 Jun 2006 16:05:02 +0000 Subject: [PATCH] - add note about removing superfluous fmt specifiers --- TODO | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/TODO b/TODO index 2a963ddb9..778e924d8 100644 --- a/TODO +++ b/TODO @@ -259,12 +259,17 @@ Minor stuff: if(!ioctl (fd, WDIOC_GETTIMEOUT, &tmo)) timer_duration = 1 + (tmo / 2); Unfortunately, that needs linux/watchdog.h and that contains unfiltered kernel types on some distros, which breaks the build. - +--- use bb_error_msg where appropriate: See egrep "(printf.*\([[:space:]]*(stderr|2)|[^_]write.*\([[:space:]]*(stderr|2))" - +--- use bb_perror_msg where appropriate: See egrep "[^_]perror" +--- + Remove superfluous fmt occurances: e.g. + fprintf(stderr, "%s: %s not found\n", "unalias", *argptr); + -> fprintf(stderr, "unalias: %s not found\n", *argptr); +--- Code cleanup: -- 2.25.1