From 83ccead4d0fb496c8f00ee53c28e957b8cab4181 Mon Sep 17 00:00:00 2001 From: Matt Caswell Date: Tue, 28 Nov 2017 10:15:15 +0000 Subject: [PATCH] Fix lshift tests Commit 30bea14be6 converted bntest.c to the new TEST framework. Unfortunately a missing "goto err" means that the lshift tests skip the actual bit that tests them. Replacing the "goto err" reveals that the conversion also broke the tests. This adds back the missing "goto err" and fixes the tests. Fixes #4808 Reviewed-by: Tim Hudson (Merged from https://github.com/openssl/openssl/pull/4809) --- test/bntest.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/test/bntest.c b/test/bntest.c index 6b7f824dd1..9eda5bd825 100644 --- a/test/bntest.c +++ b/test/bntest.c @@ -1089,7 +1089,9 @@ static int file_lshift(STANZA *s) if (!TEST_ptr(a = getBN(s, "A")) || !TEST_ptr(lshift = getBN(s, "LShift")) - || !TEST_ptr(ret = BN_new())) + || !TEST_ptr(ret = BN_new()) + || !getint(s, &n, "N")) + goto err; if (!TEST_true(BN_lshift(ret, a, n)) || !equalBN("A << N", lshift, ret) -- 2.25.1