From 7d3512126db7044525cf402255e0a85ac68dc2e9 Mon Sep 17 00:00:00 2001 From: Rich Felker Date: Thu, 18 Dec 2014 20:44:51 -0500 Subject: [PATCH] use tkill instead of tgkill in implementing raise this shaves off a useless syscall for getting the caller's pid and brings raise into alignment with other functions which were adapted to use tkill rather than tgkill. commit 83dc6eb087633abcf5608ad651d3b525ca2ec35e documents the rationale for this change, and in particular why the tgkill syscall is useless for its designed purpose of avoiding races. --- src/signal/raise.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/src/signal/raise.c b/src/signal/raise.c index 35063c5b..717b1c91 100644 --- a/src/signal/raise.c +++ b/src/signal/raise.c @@ -5,12 +5,11 @@ int raise(int sig) { - int pid, tid, ret; + int tid, ret; sigset_t set; __block_app_sigs(&set); tid = __syscall(SYS_gettid); - pid = __syscall(SYS_getpid); - ret = syscall(SYS_tgkill, pid, tid, sig); + ret = syscall(SYS_tkill, tid, sig); __restore_sigs(&set); return ret; } -- 2.25.1