From 7c20a11801fd56cbadac5a6e88ddddf8656ac1bc Mon Sep 17 00:00:00 2001 From: Rich Felker Date: Wed, 26 Jun 2013 21:41:51 -0400 Subject: [PATCH] fix temp file leak in sem_open on successful creation of new semaphore --- src/thread/sem_open.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/thread/sem_open.c b/src/thread/sem_open.c index 66f12ee4..9a95d257 100644 --- a/src/thread/sem_open.c +++ b/src/thread/sem_open.c @@ -123,9 +123,9 @@ sem_t *sem_open(const char *name, int flags, ...) goto fail; } close(fd); - if (link(tmp, name) == 0) break; - e = errno; + e = link(tmp, name) ? errno : 0; unlink(tmp); + if (!e) break; /* Failure is only fatal when doing an exclusive open; * otherwise, next iteration will try to open the * existing file. */ -- 2.25.1