From 7b36590b1778c26ad96a36002b55b17fa3e41bf6 Mon Sep 17 00:00:00 2001 From: Richard Levitte Date: Mon, 7 Apr 2003 10:15:32 +0000 Subject: [PATCH] What was I smoking? EVP_PKEY_cmp() should return with 0 if EVP_PKEY_cmp_parameters() returned 0, otherwise it should go on processing the public key component. Thia has nothing to do with the proper handling of EC parameters or not. --- crypto/evp/p_lib.c | 10 ++-------- 1 file changed, 2 insertions(+), 8 deletions(-) diff --git a/crypto/evp/p_lib.c b/crypto/evp/p_lib.c index 2760d7b1ed..730ef4d0a9 100644 --- a/crypto/evp/p_lib.c +++ b/crypto/evp/p_lib.c @@ -242,14 +242,8 @@ int EVP_PKEY_cmp(const EVP_PKEY *a, const EVP_PKEY *b) if (a->type != b->type) return -1; - /* XXXXX - We should really check for != 0, but cmp_paramters doesn't compare EC - groups, and I'm currently unsure how to handle that case... Except for - adding such functionality to cmp_parameters, but that would require - things like EC_GROUP_cmp(), which I'm not currently ready to write. - -- Richard Levitte */ - if (EVP_PKEY_cmp_parameters(a, b) == 1) - return 1; + if (EVP_PKEY_cmp_parameters(a, b) == 0) + return 0; switch (a->type) { -- 2.25.1