From 777e57cfce5f0d688d4147bf183723d539db6134 Mon Sep 17 00:00:00 2001 From: Christian Grothoff Date: Sat, 1 Jun 2019 01:05:35 +0200 Subject: [PATCH] note on why gnunet-gns can be slow --- src/gns/gns_tld_api.c | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/src/gns/gns_tld_api.c b/src/gns/gns_tld_api.c index e62bc437d..c4bf78477 100644 --- a/src/gns/gns_tld_api.c +++ b/src/gns/gns_tld_api.c @@ -128,8 +128,7 @@ static void eat_tld (char *name, const char *tld) { GNUNET_assert (0 < strlen (name)); - if ((NULL == tld) || - (strlen (name) == strlen (tld))) + if ((NULL == tld) || (strlen (name) == strlen (tld))) { strcpy (name, GNUNET_GNS_EMPTY_LABEL_AT); } @@ -337,7 +336,10 @@ GNUNET_GNS_lookup_with_tld (struct GNUNET_GNS_Handle *handle, } GNUNET_free (dot_tld); } - + /* FIXME: this call is still shitty slow to do the longest + prefix if we have thousands of egos. We should modify + the IDENTITY API to do the longest prefix matching + inside of the identity service and not do an O(n) IPC! */ ltr->id_co = GNUNET_IDENTITY_connect (ltr->gns_handle->cfg, &identity_zone_cb, ltr); if (NULL == ltr->id_co) -- 2.25.1