From 7573fe1af54c190ccd8d07d753b334637a30f3a2 Mon Sep 17 00:00:00 2001 From: Matt Caswell Date: Fri, 29 Nov 2019 12:02:54 +0000 Subject: [PATCH] Deprecate the AES_ige_*() functions These functions were already partially deprecated. Now we do it fully. Reviewed-by: Richard Levitte Reviewed-by: Tomas Mraz (Merged from https://github.com/openssl/openssl/pull/10558) --- apps/speed.c | 3 +++ include/openssl/aes.h | 19 ++++++++++--------- test/igetest.c | 3 +++ 3 files changed, 16 insertions(+), 9 deletions(-) diff --git a/apps/speed.c b/apps/speed.c index 53ae4c4e58..e4b104e9c3 100644 --- a/apps/speed.c +++ b/apps/speed.c @@ -17,6 +17,9 @@ #define EdDSA_SECONDS 10 #define SM2_SECONDS 10 +/* We need to use some deprecated APIs */ +#define OPENSSL_SUPPRESS_DEPRECATED + #include #include #include diff --git a/include/openssl/aes.h b/include/openssl/aes.h index a21e72d473..510edce18d 100644 --- a/include/openssl/aes.h +++ b/include/openssl/aes.h @@ -73,17 +73,18 @@ void AES_cfb8_encrypt(const unsigned char *in, unsigned char *out, void AES_ofb128_encrypt(const unsigned char *in, unsigned char *out, size_t length, const AES_KEY *key, unsigned char *ivec, int *num); -# ifndef OPENSSL_NO_DEPRECATED_3_0 + /* NB: the IV is _two_ blocks long */ -void AES_ige_encrypt(const unsigned char *in, unsigned char *out, - size_t length, const AES_KEY *key, - unsigned char *ivec, const int enc); +DEPRECATEDIN_3_0(void + AES_ige_encrypt(const unsigned char *in, unsigned char *out, + size_t length, const AES_KEY *key, + unsigned char *ivec, const int enc)) /* NB: the IV is _four_ blocks long */ -void AES_bi_ige_encrypt(const unsigned char *in, unsigned char *out, - size_t length, const AES_KEY *key, - const AES_KEY *key2, const unsigned char *ivec, - const int enc); -# endif +DEPRECATEDIN_3_0(void + AES_bi_ige_encrypt(const unsigned char *in, unsigned char *out, + size_t length, const AES_KEY *key, + const AES_KEY *key2, + const unsigned char *ivec, const int enc)) int AES_wrap_key(AES_KEY *key, const unsigned char *iv, unsigned char *out, diff --git a/test/igetest.c b/test/igetest.c index 5a9ebb5b56..7a8ff68802 100644 --- a/test/igetest.c +++ b/test/igetest.c @@ -7,6 +7,9 @@ * https://www.openssl.org/source/license.html */ +/* The AES_ige_* functions are deprecated, so we suppress warnings about them */ +#define OPENSSL_SUPPRESS_DEPRECATED + #include #include #include -- 2.25.1