From 722bca907b6aa69c3b617221870451ccf436921a Mon Sep 17 00:00:00 2001 From: Chocobozzz Date: Mon, 13 May 2019 10:37:55 +0200 Subject: [PATCH] Fix component reuse on channel/account videos --- .../account-videos/account-videos.component.ts | 13 +++++++------ .../video-channel-videos.component.ts | 13 +++++++------ client/src/app/app.component.ts | 4 ++-- 3 files changed, 16 insertions(+), 14 deletions(-) diff --git a/client/src/app/+accounts/account-videos/account-videos.component.ts b/client/src/app/+accounts/account-videos/account-videos.component.ts index 1814ef455..0d579fa0c 100644 --- a/client/src/app/+accounts/account-videos/account-videos.component.ts +++ b/client/src/app/+accounts/account-videos/account-videos.component.ts @@ -7,7 +7,7 @@ import { AbstractVideoList } from '../../shared/video/abstract-video-list' import { VideoService } from '../../shared/video/video.service' import { Account } from '@app/shared/account/account.model' import { AccountService } from '@app/shared/account/account.service' -import { tap } from 'rxjs/operators' +import { first, tap } from 'rxjs/operators' import { I18n } from '@ngx-translate/i18n-polyfill' import { Subscription } from 'rxjs' import { ScreenService } from '@app/shared/misc/screen.service' @@ -50,12 +50,13 @@ export class AccountVideosComponent extends AbstractVideoList implements OnInit, // Parent get the account for us this.accountSub = this.accountService.accountLoaded - .subscribe(account => { - this.account = account + .pipe(first()) + .subscribe(account => { + this.account = account - this.reloadVideos() - this.generateSyndicationList() - }) + this.reloadVideos() + this.generateSyndicationList() + }) } ngOnDestroy () { diff --git a/client/src/app/+video-channels/video-channel-videos/video-channel-videos.component.ts b/client/src/app/+video-channels/video-channel-videos/video-channel-videos.component.ts index 2045a095d..5e60b34b4 100644 --- a/client/src/app/+video-channels/video-channel-videos/video-channel-videos.component.ts +++ b/client/src/app/+video-channels/video-channel-videos/video-channel-videos.component.ts @@ -7,7 +7,7 @@ import { AbstractVideoList } from '../../shared/video/abstract-video-list' import { VideoService } from '../../shared/video/video.service' import { VideoChannelService } from '@app/shared/video-channel/video-channel.service' import { VideoChannel } from '@app/shared/video-channel/video-channel.model' -import { tap } from 'rxjs/operators' +import { first, tap } from 'rxjs/operators' import { I18n } from '@ngx-translate/i18n-polyfill' import { Subscription } from 'rxjs' import { ScreenService } from '@app/shared/misc/screen.service' @@ -50,12 +50,13 @@ export class VideoChannelVideosComponent extends AbstractVideoList implements On // Parent get the video channel for us this.videoChannelSub = this.videoChannelService.videoChannelLoaded - .subscribe(videoChannel => { - this.videoChannel = videoChannel + .pipe(first()) + .subscribe(videoChannel => { + this.videoChannel = videoChannel - this.reloadVideos() - this.generateSyndicationList() - }) + this.reloadVideos() + this.generateSyndicationList() + }) } ngOnDestroy () { diff --git a/client/src/app/app.component.ts b/client/src/app/app.component.ts index ad0588b99..915466af7 100644 --- a/client/src/app/app.component.ts +++ b/client/src/app/app.component.ts @@ -125,8 +125,8 @@ export class AppComponent implements OnInit { try { resetScroll = false - const previousUrl = new URL(window.location.origin + e1.url) - const nextUrl = new URL(window.location.origin + e2.url) + const previousUrl = new URL(window.location.origin + e1.urlAfterRedirects) + const nextUrl = new URL(window.location.origin + e2.urlAfterRedirects) if (previousUrl.pathname !== nextUrl.pathname) { resetScroll = true -- 2.25.1