From 6fd96676ab10db4864bf5efb4496e2287b8d545e Mon Sep 17 00:00:00 2001 From: ng0 Date: Fri, 22 Feb 2019 23:48:19 +0000 Subject: [PATCH] configure.ac: make it more portable. ===> Creating toolchain wrappers for gnunet-0.11.0pre66 ===> Configuring for gnunet-0.11.0pre66 => Modifying GNU configure scripts to avoid --recheck => Replacing config-guess with pkgsrc versions => Replacing config-sub with pkgsrc versions => Replacing install-sh with pkgsrc version => Checking for portability problems in extracted files ERROR: [check-portability.awk] => Found test ... == ...: ERROR: [check-portability.awk] configure: if test "x$enable_autostart" == "xno" Explanation: =========================================================================== The "test" command, as well as the "[" command, are not required to know the "==" operator. Only a few implementations like bash and some versions of ksh support it. When you run "test foo == foo" on a platform that does not support the "==" operator, the result will be "false" instead of "true". This can lead to unexpected behavior. There are two ways to fix this error message. If the file that contains the "test ==" is needed for building the package, you should create a patch for it, replacing the "==" operator with "=". If the file is not needed, add its name to the CHECK_PORTABILITY_SKIP variable in the package Makefile. =========================================================================== *** Error code 1 Stop. make[1]: stopped in /usr/pkgsrc/wip/gnunet *** Error code 1 --- configure.ac | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/configure.ac b/configure.ac index 317a9b6a2..87a60cb04 100644 --- a/configure.ac +++ b/configure.ac @@ -1530,7 +1530,7 @@ AC_MSG_CHECKING(whether to start peer's services on demand by default) AC_ARG_ENABLE([autostart], [AS_HELP_STRING([--disable-autostart], [do not start peer's services by default])], [enable_autostart=${enableval} - if test "x$enable_autostart" == "xno" + if test "x$enable_autostart" = "xno" then START_ON_DEMAND="NO" fi -- 2.25.1