From 6bdd2637daa862706598d04ae2750a920ebee0ae Mon Sep 17 00:00:00 2001 From: Matt Caswell Date: Wed, 14 Sep 2016 13:27:59 +0100 Subject: [PATCH] Fix a missing NULL check in dsa_builtin_paramgen We should check the last BN_CTX_get() call to ensure that it isn't NULL before we try and use any of the allocated BIGNUMs. Issue reported by Shi Lei. Reviewed-by: Richard Levitte (cherry picked from commit 1ff7425d6130380bb00d3e64739633a4b21b11a3) --- crypto/dsa/dsa_gen.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/crypto/dsa/dsa_gen.c b/crypto/dsa/dsa_gen.c index 3dac550031..11f422e4b4 100644 --- a/crypto/dsa/dsa_gen.c +++ b/crypto/dsa/dsa_gen.c @@ -100,6 +100,9 @@ int dsa_builtin_paramgen(DSA *ret, size_t bits, size_t qbits, p = BN_CTX_get(ctx); test = BN_CTX_get(ctx); + if (test == NULL) + goto err; + if (!BN_lshift(test, BN_value_one(), bits - 1)) goto err; -- 2.25.1