From 69d6542848ed712a79dcba4965da4100e2804dd7 Mon Sep 17 00:00:00 2001 From: Felix Fietkau Date: Mon, 6 Nov 2017 11:11:49 +0100 Subject: [PATCH] logd: only create pipe in stream mode Signed-off-by: Felix Fietkau --- log/logd.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/log/logd.c b/log/logd.c index 9b481cd..58abfad 100644 --- a/log/logd.c +++ b/log/logd.c @@ -103,13 +103,13 @@ read_log(struct ubus_context *ctx, struct ubus_object *obj, stream = blobmsg_get_bool(tb[READ_STREAM]); } - if (pipe(fds) == -1) { - fprintf(stderr, "logd: failed to create pipe: %s\n", strerror(errno)); - return -1; - } - l = log_list(count, NULL); if (stream) { + if (pipe(fds) == -1) { + fprintf(stderr, "logd: failed to create pipe: %s\n", strerror(errno)); + return -1; + } + ubus_request_set_fd(ctx, req, fds[0]); cl = calloc(1, sizeof(*cl)); cl->s.stream.notify_state = client_notify_state; -- 2.25.1