From 68ad17e87467e93eab87fc2fce0da53d6a7653cc Mon Sep 17 00:00:00 2001 From: Pauli Date: Mon, 4 Mar 2019 13:37:39 +1000 Subject: [PATCH] Check for negative return for signature size.Addresses Coverity 1442933 Reviewed-by: Matt Caswell (Merged from https://github.com/openssl/openssl/pull/8392) --- test/ecdsatest.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/test/ecdsatest.c b/test/ecdsatest.c index 03327a23dc..761832ff81 100644 --- a/test/ecdsatest.c +++ b/test/ecdsatest.c @@ -205,6 +205,7 @@ static int test_builtin(int n) EVP_MD_CTX *mctx = NULL; size_t sig_len; int nid, ret = 0; + int temp; nid = curves[n].nid; @@ -231,9 +232,10 @@ static int test_builtin(int n) || !TEST_true(EVP_PKEY_assign_EC_KEY(pkey_neg, eckey_neg))) goto err; - sig_len = ECDSA_size(eckey); + temp = ECDSA_size(eckey); - if (!TEST_ptr(sig = OPENSSL_malloc(sig_len)) + if (!TEST_int_ge(temp, 0) + || !TEST_ptr(sig = OPENSSL_malloc(sig_len = (size_t)temp)) /* create a signature */ || !TEST_true(EVP_DigestSignInit(mctx, NULL, NULL, NULL, pkey)) || !TEST_true(EVP_DigestSign(mctx, sig, &sig_len, tbs, sizeof(tbs))) -- 2.25.1