From 684f7dd7dc21e61a73ecf20f9e6e158af39872a6 Mon Sep 17 00:00:00 2001 From: Jo-Philipp Wich Date: Thu, 16 Apr 2020 15:35:13 +0200 Subject: [PATCH] luci-mod-system: flash.js: make readonly on insufficient ACLs Signed-off-by: Jo-Philipp Wich --- .../htdocs/luci-static/resources/view/system/flash.js | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/modules/luci-mod-system/htdocs/luci-static/resources/view/system/flash.js b/modules/luci-mod-system/htdocs/luci-static/resources/view/system/flash.js index b058091f9..c1e127377 100644 --- a/modules/luci-mod-system/htdocs/luci-static/resources/view/system/flash.js +++ b/modules/luci-mod-system/htdocs/luci-static/resources/view/system/flash.js @@ -6,6 +6,8 @@ 'require fs'; 'require ui'; +var isReadonlyView = !L.hasViewPermission(); + var callSystemValidateFirmwareImage = rpc.declare({ object: 'system', method: 'validate_firmware_image', @@ -353,6 +355,7 @@ return view.extend({ m = new form.JSONMap(mapdata, _('Flash operations')); m.tabbed = true; + m.readonly = isReadonlyView; s = m.section(form.NamedSection, 'actions', _('Actions')); @@ -422,7 +425,8 @@ return view.extend({ node.appendChild(E('div', { 'class': 'cbi-page-actions' }, [ E('button', { 'class': 'cbi-button cbi-button-save', - 'click': ui.createHandlerFn(view, 'handleBackupSave', this.map) + 'click': ui.createHandlerFn(view, 'handleBackupSave', this.map), + 'disabled': isReadonlyView }, [ _('Save') ]) ])); -- 2.25.1