From 63a65d16acca53622a08861cdde8fe0e79beb522 Mon Sep 17 00:00:00 2001 From: "Dr. Matthias St. Pierre" Date: Sun, 8 Apr 2018 12:09:10 +0200 Subject: [PATCH] DRBG: fix memory leak on error in rand_drbg_get_entropy() Reviewed-by: Richard Levitte (Merged from https://github.com/openssl/openssl/pull/5918) --- crypto/rand/rand_lib.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/crypto/rand/rand_lib.c b/crypto/rand/rand_lib.c index 3589e75853..6e98e4ddf8 100644 --- a/crypto/rand/rand_lib.c +++ b/crypto/rand/rand_lib.c @@ -229,7 +229,7 @@ size_t rand_drbg_get_entropy(RAND_DRBG *drbg, */ RANDerr(RAND_F_RAND_DRBG_GET_ENTROPY, RAND_R_PREDICTION_RESISTANCE_NOT_SUPPORTED); - return 0; + goto err; } /* Get entropy by polling system entropy sources. */ @@ -241,6 +241,7 @@ size_t rand_drbg_get_entropy(RAND_DRBG *drbg, *pout = rand_pool_detach(pool); } + err: rand_pool_free(pool); return ret; } -- 2.25.1