From 5f80315634c66a647aed9673e10582acd8462d69 Mon Sep 17 00:00:00 2001 From: Jo-Philipp Wich Date: Tue, 4 Oct 2016 11:04:50 +0200 Subject: [PATCH] include: add umask prereq check When building LEDE with umask values other than 022, the resulting packages will embed improper permissions, which may lead to random errors or non- functional scripts on the target. In order to make users aware of this problem, add a build-prereq check to assert a correct umask setting before starting the build. Signed-off-by: Jo-Philipp Wich --- include/prereq-build.mk | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/include/prereq-build.mk b/include/prereq-build.mk index 9c0717d53a..c3b88db627 100644 --- a/include/prereq-build.mk +++ b/include/prereq-build.mk @@ -24,6 +24,10 @@ $(eval $(call TestHostCommand,case-sensitive-fs, \ rm -f $(TMP_DIR)/test.*; touch $(TMP_DIR)/test.fs; \ test ! -f $(TMP_DIR)/test.FS)) +$(eval $(call TestHostCommand,proper-umask, \ + Please build with umask 022 - other values produce broken packages, \ + umask | grep -xF 0022)) + $(eval $(call SetupHostCommand,gcc, \ Please install the GNU C Compiler (gcc), \ $(CC) --version | grep gcc, \ -- 2.25.1