From 5b5a82eb7054869e869c2aa3c7018fe50a84c47a Mon Sep 17 00:00:00 2001 From: Marek Vasut Date: Wed, 4 Dec 2013 14:27:40 +0100 Subject: [PATCH] ARM: mxs: tools: Fix errno handling in strtoul() invocation According to NOTE in strtoul(3), the errno must be zeroed before strtoul() is called. Zero the errno. The NOTE reads as such: Since strtoul() can legitimately return 0 or ULONG_MAX (ULLONG_MAX for strtoull()) on both success and failure, the calling program should set errno to 0 before the call, and then determine if an error occurred by checking whether errno has a nonzero value after the call. This issue was detected on Fedora 19 with glibc 2.17 . Signed-off-by: Marek Vasut Cc: Stefano Babic Cc: Tom Rini --- tools/mxsimage.c | 1 + 1 file changed, 1 insertion(+) diff --git a/tools/mxsimage.c b/tools/mxsimage.c index 5db19b216f..7bd9deef5f 100644 --- a/tools/mxsimage.c +++ b/tools/mxsimage.c @@ -502,6 +502,7 @@ static int sb_token_to_long(char *tok, uint32_t *rid) tok += 2; + errno = 0; id = strtoul(tok, &endptr, 16); if ((errno == ERANGE && id == ULONG_MAX) || (errno != 0 && id == 0)) { fprintf(stderr, "ERR: Value can't be decoded!\n"); -- 2.25.1