From 5729327cc8e76a3a6c3e94096c91b92a3fe09eed Mon Sep 17 00:00:00 2001 From: Jon Trulson Date: Sun, 1 Apr 2018 13:54:22 -0600 Subject: [PATCH] dtexec,DtSvc/MsgLog.c: coverity CID 89585; resource leak --- cde/lib/DtSvc/DtUtil2/MsgLog.c | 13 +++++++------ 1 file changed, 7 insertions(+), 6 deletions(-) diff --git a/cde/lib/DtSvc/DtUtil2/MsgLog.c b/cde/lib/DtSvc/DtUtil2/MsgLog.c index 0aa48d1d..8997b745 100644 --- a/cde/lib/DtSvc/DtUtil2/MsgLog.c +++ b/cde/lib/DtSvc/DtUtil2/MsgLog.c @@ -141,7 +141,7 @@ static char * get_file_name ( const char * format, ... ) { - char *file, *rtn; + char *file; va_list args; file = malloc(MAXPATHLEN+1); @@ -153,11 +153,12 @@ static char * get_file_name ( va_end (args); if ((*fp = fopen (file, type)) == NULL) - return (NULL); - - rtn = strdup (file); - free(file); - return rtn; + { + free(file); + return (NULL); + } + + return file; } -- 2.25.1