From 543efd7b4b4265ae507b4e3b048bf23a51a726fc Mon Sep 17 00:00:00 2001 From: Denys Vlasenko Date: Tue, 6 Aug 2013 00:41:06 +0200 Subject: [PATCH] libbb: code shrink function old new delta xmalloc_ttyname 46 42 -4 Signed-off-by: Denys Vlasenko --- libbb/xfuncs_printf.c | 12 +++++------- 1 file changed, 5 insertions(+), 7 deletions(-) diff --git a/libbb/xfuncs_printf.c b/libbb/xfuncs_printf.c index 05aa07ce8..a70683241 100644 --- a/libbb/xfuncs_printf.c +++ b/libbb/xfuncs_printf.c @@ -541,13 +541,11 @@ int FAST_FUNC bb_xioctl(int fd, unsigned request, void *argp) char* FAST_FUNC xmalloc_ttyname(int fd) { - char *buf = xzalloc(128); - int r = ttyname_r(fd, buf, 127); - if (r) { - free(buf); - buf = NULL; - } - return buf; + char buf[128]; + int r = ttyname_r(fd, buf, sizeof(buf) - 1); + if (r) + return NULL; + return xstrdup(buf); } void FAST_FUNC generate_uuid(uint8_t *buf) -- 2.25.1