From 54222d1efc5239d3fc8c528672bd52bfd8dad813 Mon Sep 17 00:00:00 2001 From: Rich Felker Date: Fri, 13 Apr 2012 03:26:59 -0400 Subject: [PATCH] fix spurious overflows in strtoull with small bases whenever the base was small enough that more than one digit could still fit after UINTMAX_MAX/36-1 was reached, only the first would be allowed; subsequent digits would trigger spurious overflow, making it impossible to read the largest values in low bases. --- src/internal/intparse.c | 10 +++------- 1 file changed, 3 insertions(+), 7 deletions(-) diff --git a/src/internal/intparse.c b/src/internal/intparse.c index ffd06fe0..e30a1a58 100644 --- a/src/internal/intparse.c +++ b/src/internal/intparse.c @@ -25,12 +25,12 @@ static const unsigned char digits[] = { }; #define SLIM (UINT_MAX/36-1) -#define LLIM (UINTMAX_MAX/36-1) int __intparse(struct intparse *v, const void *buf, size_t n) { const unsigned char *s = buf; int d, b = v->base; + uintmax_t llim; v->cnt += n; for (; n; n--, s++) switch (v->state) { @@ -83,16 +83,12 @@ int __intparse(struct intparse *v, const void *buf, size_t n) v->state++; v->val = v->small; case 5: - for (; n && (d=digits[*s])val<=LLIM; n--, s++) + llim = UINTMAX_MAX/b; + for (; n && (d=digits[*s])val<=llim && d<=UINTMAX_MAX-v->val*b; n--, s++) v->val = v->val * b + d; if (!n) return 1; if (d >= b) goto finished; - if (v->val <= (UINTMAX_MAX-d)/b) - v->val = v->val * b + d; - else - v->err = ERANGE; v->state++; - n--; s++; case 6: if (n && digits[*s]err = ERANGE; -- 2.25.1