From 52edfed65de967a86983a55c51ba0727090efc43 Mon Sep 17 00:00:00 2001 From: Anatolij Gustschin Date: Fri, 27 Sep 2019 13:48:15 +0530 Subject: [PATCH] dm: core: device: switch off power domain after device removal The power domain associated with a device is enabled when probing, but currently the domain remains enabled when the device is removed. Some boards started to disable power domains for selected devices via custom board_quiesce_devices(), but it doesn't work in many cases, i. e. because devices still can be accessed later in .remove() callback on behalf of dm_remove_devices_flags(). Utilize the DM core to power off the device power domain, but add a device flag to be able to selectively let the power domain enabled after device removal. This might be required for devices that must remain enabled when booting OS, i. e. serial console for debug output, etc. Signed-off-by: Anatolij Gustschin Signed-off-by: Lokesh Vutla Reviewed-by: Simon Glass --- drivers/core/device-remove.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/drivers/core/device-remove.c b/drivers/core/device-remove.c index 586fadee0a..5c8dc4ad70 100644 --- a/drivers/core/device-remove.c +++ b/drivers/core/device-remove.c @@ -16,6 +16,7 @@ #include #include #include +#include int device_chld_unbind(struct udevice *dev, struct driver *drv) { @@ -192,6 +193,10 @@ int device_remove(struct udevice *dev, uint flags) } } + if (!(drv->flags & DM_FLAG_DEFAULT_PD_CTRL_OFF) && + (dev != gd->cur_serial_dev)) + dev_power_domain_off(dev); + if (flags_remove(flags, drv->flags)) { device_free(dev); -- 2.25.1