From 4dea1edd08a45c5987448719e56ee61a20fb9210 Mon Sep 17 00:00:00 2001 From: Denys Vlasenko Date: Mon, 7 Aug 2017 02:21:34 +0200 Subject: [PATCH] script: -f means "flush", not "fsync" function old new delta packed_usage 31765 31768 +3 script_main 1102 1082 -20 Signed-off-by: Denys Vlasenko --- util-linux/script.c | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/util-linux/script.c b/util-linux/script.c index 62a241762..89b439163 100644 --- a/util-linux/script.c +++ b/util-linux/script.c @@ -27,7 +27,8 @@ //usage: "\n" //usage: "\n -a Append output" //usage: "\n -c PROG Run PROG, not shell" -//usage: "\n -f Flush output after each write" +/* Accepted but has no effect (we never buffer output) */ +/*//usage: "\n -f Flush output after each write"*/ //usage: "\n -q Quiet" //usage: "\n -t[FILE] Send timing to stderr or FILE" @@ -178,9 +179,10 @@ int script_main(int argc UNUSED_PARAM, char **argv) } full_write(STDOUT_FILENO, buf, count); full_write(outfd, buf, count); - if (opt & OPT_f) { - fsync(outfd); - } + // If we'd be using (buffered) FILE i/o, we'd need this: + //if (opt & OPT_f) { + // fflush(outfd); + //} } } if (pfd[1].revents) { -- 2.25.1