From 4d04226c2ec7e7f69f6234def63631648e35e828 Mon Sep 17 00:00:00 2001 From: Emilia Kasper Date: Mon, 31 Aug 2015 13:57:44 +0200 Subject: [PATCH] Fix spurious bntest failures. BN_bntest_rand generates a single-word zero BIGNUM with quite a large probability. A zero BIGNUM in turn will end up having a NULL |d|-buffer, which we shouldn't dereference without checking. Reviewed-by: Richard Levitte --- test/bntest.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/test/bntest.c b/test/bntest.c index cf4d2ab3a6..430d2a02b8 100644 --- a/test/bntest.c +++ b/test/bntest.c @@ -526,9 +526,9 @@ int test_div_word(BIO *bp) do { BN_bntest_rand(a, 512, -1, 0); BN_bntest_rand(b, BN_BITS2, -1, 0); - s = b->d[0]; - } while (!s); + } while (BN_is_zero(b)); + s = b->d[0]; BN_copy(b, a); r = BN_div_word(b, s); -- 2.25.1