From 4a98bb0068cae9fbe5c6a6e513093d41969dad58 Mon Sep 17 00:00:00 2001 From: Matt Caswell Date: Mon, 10 Sep 2018 16:23:14 +0100 Subject: [PATCH] Check the return value from ASN1_INTEGER_set Found by Coverity Reviewed-by: Richard Levitte (Merged from https://github.com/openssl/openssl/pull/7169) (cherry picked from commit 512d811719fc955f574090af4c3586a9aba46fa7) --- crypto/pkcs12/p12_init.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/crypto/pkcs12/p12_init.c b/crypto/pkcs12/p12_init.c index 0322df944a..8275a23fb5 100644 --- a/crypto/pkcs12/p12_init.c +++ b/crypto/pkcs12/p12_init.c @@ -70,7 +70,8 @@ PKCS12 *PKCS12_init(int mode) PKCS12err(PKCS12_F_PKCS12_INIT, ERR_R_MALLOC_FAILURE); return NULL; } - ASN1_INTEGER_set(pkcs12->version, 3); + if (!ASN1_INTEGER_set(pkcs12->version, 3)) + goto err; pkcs12->authsafes->type = OBJ_nid2obj(mode); switch (mode) { case NID_pkcs7_data: -- 2.25.1