From 45204b1025e4e2a5cb984caab3adfdf53e658765 Mon Sep 17 00:00:00 2001 From: Heinrich Schuchardt Date: Sat, 3 Mar 2018 15:29:01 +0100 Subject: [PATCH] efi_loader: do_bootefi_exec should always return an EFI status code The return type of do_bootefi_exec() is efi_status_t. So in case of an error we should always return an EFI status code. Signed-off-by: Heinrich Schuchardt Signed-off-by: Alexander Graf --- cmd/bootefi.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/cmd/bootefi.c b/cmd/bootefi.c index 3f4f214a81..9f02c5a664 100644 --- a/cmd/bootefi.c +++ b/cmd/bootefi.c @@ -164,7 +164,7 @@ static efi_status_t do_bootefi_exec(void *efi, void *fdt, struct efi_loaded_image loaded_image_info = {}; struct efi_object loaded_image_info_obj = {}; struct efi_device_path *memdp = NULL; - ulong ret; + efi_status_t ret; EFIAPI efi_status_t (*entry)(efi_handle_t image_handle, struct efi_system_table *st); @@ -229,7 +229,7 @@ static efi_status_t do_bootefi_exec(void *efi, void *fdt, /* Load the EFI payload */ entry = efi_load_pe(efi, &loaded_image_info); if (!entry) { - ret = -ENOENT; + ret = EFI_LOAD_ERROR; goto exit; } -- 2.25.1