From 432f8688bb72e21939845ac7a69359ca718c6676 Mon Sep 17 00:00:00 2001 From: Andy Polyakov Date: Sat, 14 Oct 2017 10:21:19 +0200 Subject: [PATCH] x509v3/v3_utl.c: avoid double-free. Thanks to David Benjamin for spotting this. Reviewed-by: Rich Salz Reviewed-by: Richard Levitte (Merged from https://github.com/openssl/openssl/pull/4532) --- crypto/x509v3/v3_utl.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/crypto/x509v3/v3_utl.c b/crypto/x509v3/v3_utl.c index a839861dba..4dbcfaa430 100644 --- a/crypto/x509v3/v3_utl.c +++ b/crypto/x509v3/v3_utl.c @@ -56,8 +56,10 @@ int X509V3_add_value(const char *name, const char *value, return 1; err: X509V3err(X509V3_F_X509V3_ADD_VALUE, ERR_R_MALLOC_FAILURE); - if (sk_allocated) + if (sk_allocated) { sk_CONF_VALUE_free(*extlist); + *extlist = NULL; + } OPENSSL_free(vtmp); OPENSSL_free(tname); OPENSSL_free(tvalue); -- 2.25.1