From 42aac9fcfc837ddd60ac304a6e0f54b6e0e7a8e0 Mon Sep 17 00:00:00 2001 From: Chocobozzz Date: Mon, 28 Oct 2019 09:37:33 +0100 Subject: [PATCH] Fix player captions menu --- .../assets/player/videojs-components/settings-menu-item.ts | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/client/src/assets/player/videojs-components/settings-menu-item.ts b/client/src/assets/player/videojs-components/settings-menu-item.ts index b738300ae..85172a18c 100644 --- a/client/src/assets/player/videojs-components/settings-menu-item.ts +++ b/client/src/assets/player/videojs-components/settings-menu-item.ts @@ -75,7 +75,6 @@ class SettingsMenuItem extends MenuItem { this.settingsSubMenuEl_.appendChild(this.subMenu.menu.el_) this.update() this.bindClickEvents() - }, 0) }) } @@ -107,6 +106,10 @@ class SettingsMenuItem extends MenuItem { // To update the sub menu value on click, setTimeout is needed because // updating the value is not instant setTimeout(() => this.update(event), 0) + + // Seems like videojs adds a vjs-hidden class on the caption menu after a click + // We don't need it + this.subMenu.menu.removeClass('vjs-hidden') } /** -- 2.25.1