From 41bffb9da082e49378ef0c027beac75399315bb9 Mon Sep 17 00:00:00 2001 From: Eneas U de Queiroz Date: Fri, 15 Feb 2019 15:51:59 -0200 Subject: [PATCH] engines/e_devcrypto: fixes logic in close_devcrypto Call close(cfd) before setting cfd = -1. Signed-off-by: Eneas U de Queiroz Reviewed-by: Paul Dale Reviewed-by: Richard Levitte (Merged from https://github.com/openssl/openssl/pull/8213) --- engines/e_devcrypto.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/engines/e_devcrypto.c b/engines/e_devcrypto.c index 359a48631a..c57862969e 100644 --- a/engines/e_devcrypto.c +++ b/engines/e_devcrypto.c @@ -1183,10 +1183,13 @@ static int open_devcrypto(void) static int close_devcrypto(void) { + int ret; + if (cfd < 0) return 1; + ret = close(cfd); cfd = -1; - if (close(cfd) == 0) { + if (ret != 0) { fprintf(stderr, "Error closing /dev/crypto: %s\n", strerror(errno)); return 0; } -- 2.25.1